Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fips): bump sarama to drop kerberos lib in fips mode #43061

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(fips): bump sarama to drop kerberos lib in fips mode #43061

wants to merge 4 commits into from

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Mar 6, 2025

Proposed commit message

bump sarama to latest commit and verify kerberos lib is not linked in the binary

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kruskall
feat(fips): bump sarama to drop kerberos lib in fips mode
8304db7 
bump sarama to latest commit and verify kerberos lib is not linked in the
binary
@kruskall kruskall added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Mar 6, 2025
@kruskall kruskall requested a review from a team as a code owner March 6, 2025 03:53
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2025
@pierrehilbert pierrehilbert requested a review from faec March 7, 2025 08:00
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 7, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2025
faec
faec reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@faec faec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine once the tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faec faec faec left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kruskall kruskall

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kruskall @elasticmachine @faec @pierrehilbert